From 7c586e098439037c5f581fb0db3ddc3d78e351f7 Mon Sep 17 00:00:00 2001
From: Index <xv.media.address@gmail.com>
Date: Sun, 30 Jun 2024 03:40:40 -0500
Subject: [PATCH] minor: ability to toggle QOL achievement features

previously, there wasn't an option to disable those small, quality-of-life achievement features
---
 js/background.js        |  8 +++++++-
 js/places/place-view.js | 20 ++++++++++++++------
 resources/utils.js      |  8 +++++++-
 settings.html           | 27 +++++++++++++++++++++++++++
 4 files changed, 55 insertions(+), 8 deletions(-)

diff --git a/js/background.js b/js/background.js
index 3e688d1..9c9e7dd 100755
--- a/js/background.js
+++ b/js/background.js
@@ -89,7 +89,13 @@ const DefaultSettings = {
 		LeaderboardsOn: true
 	},
 	CollectibleInventoryCatOn: true,
-	ShowValueListDataOn: true
+	ShowValueListDataOn: true,
+	ImprovedAchievements: {
+		Enabled: true,
+		ProgressBarOn: true,
+		PercentageOn: true,
+		OpacityOn: true
+	}
 }
 
 // ON EXTENSION INSTALL / RELOAD
diff --git a/js/places/place-view.js b/js/places/place-view.js
index 12bc689..d25443b 100644
--- a/js/places/place-view.js
+++ b/js/places/place-view.js
@@ -95,13 +95,21 @@ const Gamepasses = Array.from(GamepassesTab.getElementsByClassName('card')) || [
 			});
 		}
 
-		if (AchievementsTab.getElementsByClassName('display-3')[0] === undefined) {
-			AchievementProgressBar();
-			AchievementEarnedPercentage();
+		if (Settings.ImprovedAchievements && Settings.ImprovedAchievements.Enabled === true && AchievementsTab.getElementsByClassName('display-3')[0] === undefined) {
+			if (Settings.ImprovedAchievements.ProgressBarOn && Settings.ImprovedAchievements.ProgressBarOn === true) {
+				AchievementProgressBar();
+			}
 
-			for (let achievement of Achievements) {
-				if ((achievement.getElementsByClassName('fad fa-check-circle')[0] !== undefined) === false) {
-					achievement.style.opacity = '0.5';
+			if (Settings.ImprovedAchievements.PercentageOn && Settings.ImprovedAchievements.PercentageOn === true) {
+				AchievementEarnedPercentage();
+			}
+
+			if (Settings.ImprovedAchievements.OpacityOn && Settings.ImprovedAchievements.OpacityOn === true) {
+				console.log(Settings)
+				for (let achievement of Achievements) {
+					if ((achievement.getElementsByClassName('fad fa-check-circle')[0] !== undefined) === false) {
+						achievement.style.opacity = '0.5';
+					}
 				}
 			}
 		}
diff --git a/resources/utils.js b/resources/utils.js
index a7b1144..cdce273 100644
--- a/resources/utils.js
+++ b/resources/utils.js
@@ -109,7 +109,13 @@ export default {
 			LeaderboardsOn: true
 		},
 		CollectibleInventoryCatOn: true,
-		ShowValueListDataOn: true
+		ShowValueListDataOn: true,
+		ImprovedAchievements: {
+			Enabled: true,
+			ProgressBarOn: true,
+			PercentageOn: true,
+			OpacityOn: true
+		}
 	},
 	Limits: {
 		PinnedGames: 10,
diff --git a/settings.html b/settings.html
index 9116336..9c439ba 100755
--- a/settings.html
+++ b/settings.html
@@ -604,6 +604,33 @@
 					<option value="35">Min. 35+ Copies</option>
 				</select>
 			</div>
+			<div class="setting-container" id="improved-achievements">
+				<span class="badge bg-primary mb-1">Now a Setting!</span>
+				<br>
+				<span class="indicator">&nbsp;</span>
+				<span class="title">
+					Improved Achievements
+				</span>
+				<div class="setting-buttons">
+					<button class="btn btn-sm toggle-btn" data-setting="Enabled" data-parent="ImprovedAchievements">Toggle</button>
+				</div>
+				<br />
+				<span class="desc">
+					Quality-of-life improvements to achievements!
+				</span>
+				<span class="form-check form-switch">
+					<input class="form-check-input" type="checkbox" role="switch" id="progress-improved-achievements" data-setting="ProgressBarOn" data-parent="ImprovedAchievements" />
+					<label class="form-check-label" for="progress-improved-achievements"> Progress Bar on All Achievements in Place </label>
+				</span>
+				<span class="form-check form-switch">
+					<input class="form-check-input" type="checkbox" role="switch" id="percentage-improved-achievements" data-setting="PercentageOn" data-parent="ImprovedAchievements" />
+					<label class="form-check-label" for="percentage-improved-achievements"> Percentage of Players (& difficulty) </label>
+				</span>
+				<span class="form-check form-switch">
+					<input class="form-check-input" type="checkbox" role="switch" id="opacity-improved-achievements" data-setting="OpacityOn" data-parent="ImprovedAchievements" />
+					<label class="form-check-label" for="opacity-improved-achievements"> Fade out unowned achievements </label>
+				</span>
+			</div>
 			<div class="setting-container" id="hoarders-list">
 				<span class="indicator">&nbsp;</span>
 				<span class="title">